Skip to content

Add fisp scan#135

Merged
david-roper merged 3 commits intoCoBrALab:mainfrom
david-roper:add-fisp-scan
Mar 3, 2026
Merged

Add fisp scan#135
david-roper merged 3 commits intoCoBrALab:mainfrom
david-roper:add-fisp-scan

Conversation

@david-roper
Copy link
Collaborator

@david-roper david-roper commented Feb 26, 2026

Add fisp as a scan in MRI form

closes issue #129 and #101

Summary by CodeRabbit

  • New Features

    • Added Neo_Struct_FISP as a selectable MRI scan type in the mouse MRI form.
  • Bug Fixes / Validation

    • Updated form validation and rendering so Neo_Struct_FISP is accepted and processed correctly.
  • Chores

    • Bumped internal edition/version used by the form.

@david-roper david-roper self-assigned this Feb 26, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5682e5b and bf23e58.

📒 Files selected for processing (1)
  • public/forms/CoBrALab-Mouse-MRI-Form/index.ts

📝 Walkthrough

Walkthrough

A single configuration file was updated to add support for a new MRI scan option called Neo_Struct_FISP. The internal edition was incremented from 3 to 4, and the scan option was registered in both the available options map and the validation schema.

Changes

Cohort / File(s) Summary
MRI Form Configuration Update
public/forms/CoBrALab-Mouse-MRI-Form/index.ts
Added new scan name option Neo_Struct_FISP to the scanNameOptions map, updated internal edition from 3 to 4, and extended the scanRecordInfo.mriScanName enum to include the new scan option for validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • gdevenyi

Poem

🐰 I hopped through code and found a gift,
Neo_Struct_FISP now gives scans a lift,
Edition bumped to four with cheer,
Validation welcomes the newcomer here,
Hooray — the rabbit dances near!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add fisp scan' accurately reflects the main change: adding a new FISP scan option (Neo_Struct_FISP) to the MRI form validation and rendering.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
public/forms/CoBrALab-Mouse-MRI-Form/index.ts (1)

20-21: Minor formatting inconsistency.

Line 21 is missing a space after the colon, unlike the other entries in this map.

🔧 Suggested fix
   "exvivoDanFLASH": "exvivoDanFLASH",
-  "Neo_Struct_FISP":"Neo_Struct_FISP"
+  "Neo_Struct_FISP": "Neo_Struct_FISP"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@public/forms/CoBrALab-Mouse-MRI-Form/index.ts` around lines 20 - 21, The
object mapping shows a formatting inconsistency: the entry for "Neo_Struct_FISP"
uses "Neo_Struct_FISP":"Neo_Struct_FISP" without a space after the colon while
other entries like "exvivoDanFLASH": "exvivoDanFLASH" include a space; update
the "Neo_Struct_FISP" entry to match the same formatting style by adding a space
after the colon so it reads like the others.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@public/forms/CoBrALab-Mouse-MRI-Form/index.ts`:
- Around line 20-21: The object mapping shows a formatting inconsistency: the
entry for "Neo_Struct_FISP" uses "Neo_Struct_FISP":"Neo_Struct_FISP" without a
space after the colon while other entries like "exvivoDanFLASH":
"exvivoDanFLASH" include a space; update the "Neo_Struct_FISP" entry to match
the same formatting style by adding a space after the colon so it reads like the
others.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7bc15e3 and 5682e5b.

📒 Files selected for processing (1)
  • public/forms/CoBrALab-Mouse-MRI-Form/index.ts

@david-roper david-roper merged commit 1dbde04 into CoBrALab:main Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant